Merged
Conversation
Contributor
Author
|
Amended with nit. |
grpc/lb/v1/load_balancer.proto
Outdated
| // Name of load balanced service (IE, service.googleapis.com). Its | ||
| // length should be less than 256 bytes. | ||
| // The name of the load balanced service (e.g., balancer.service.com). The max | ||
| // length of the name is 256 bytes. |
Contributor
Author
There was a problem hiding this comment.
I just checked with the LB folks. We actually don't see apparent limitation to this length in our LB implementation. We definitely need to discuss it and make the requirement clear. Before any decision is made, let me keep the old one.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I changed this in grpc repo before. I feel it's worth keeping because it does clarify the port thing.