Add List method to gRPC Health service#143
Merged
markdroth merged 6 commits intogrpc:masterfrom Mar 26, 2025
marcoshuck:health_list
Merged
Add List method to gRPC Health service#143markdroth merged 6 commits intogrpc:masterfrom marcoshuck:health_list
markdroth merged 6 commits intogrpc:masterfrom
marcoshuck:health_list
Conversation
marcoshuck
commented
Feb 12, 2024
Contributor
Author
|
Proposal: grpc/proposal#468 |
Falco20019
reviewed
Dec 18, 2024
purnesh42H
reviewed
Mar 10, 2025
dfawley
reviewed
Mar 20, 2025
Member
Signed-off-by: Marcos Huck <[email protected]>
dfawley
reviewed
Mar 24, 2025
Signed-off-by: Marcos Huck <[email protected]>
dfawley
approved these changes
Mar 24, 2025
Member
dfawley
left a comment
There was a problem hiding this comment.
Looks good, thank you for the changes!
markdroth
approved these changes
Mar 25, 2025
Member
|
@ejona86, please take a look, and then we can get this merged. |
ejona86
approved these changes
Mar 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Clients cannot get a list of the services a certain server is watching to and their respective status.
In the context of Kubernetes, we have
livezandreadyzendpoints, by listing all the services a server is checking, we could return a response like the/readyz?verboseKubernetes API returns:Use case
This is not only useful for having status reports like Kubernetes
readyzendpoints; it also allows services to simplify the set up when creating microservices that publish their status to status page systems such as:Change
This PR introduces a new
Listendpoint to theHealthservice in order to list all the services that a certain server is watching to.Alternative solution
We could extract the
Listendpoint into a new service to avoid breaking thev1API. A newHealthLister(or any other name) must be created.Proposal
grpc/proposal#468