Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change ArgumentCaptor.forClass(null) to ArgumentCaptor.forClass(Foo.class) #9791

Merged
merged 1 commit into from
Jan 9, 2023
Merged

Change ArgumentCaptor.forClass(null) to ArgumentCaptor.forClass(Foo.class) #9791

merged 1 commit into from
Jan 9, 2023

Conversation

ejona86
Copy link
Member

@ejona86 ejona86 commented Jan 6, 2023

The former will soon throw NullPointerException.

This is an export of cl/499211958

@ejona86 ejona86 requested a review from sergiitk January 6, 2023 16:52
@ejona86
Copy link
Member Author

ejona86 commented Jan 6, 2023

CC @cpovirk

@cpovirk cpovirk mentioned this pull request Jan 6, 2023
Merged
8 tasks
@ejona86 ejona86 merged commit c0de130 into grpc:master Jan 9, 2023
@ejona86 ejona86 deleted the export-499211958 branch January 9, 2023 15:15
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sergiitk sergiitk sergiitk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ejona86 @sergiitk @cpovirk