core: change the mapping from ChannelLogLevel to java.util.logging.Level#8531
Merged
zhangkun83 merged 1 commit intogrpc:masterfrom Sep 22, 2021
Merged
Conversation
ZhouyihaiDing
force-pushed
the
channel_logger_map
branch
from
e2035e0 to
188ecd9
Compare
zhangkun83
changed the title
zhangkun83
changed the title
ejona86
approved these changes
Sep 22, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of
ChannelLogLevel.{DEBUG,INFO}mapping to the same java level,ChannelLogLevel.{WARNING,ERROR}will shame the same java level. This allows us to be able to independently control the visibility ofChannelLogLevel.DEBUGlogs which are the most verbose.