AdvancedTls: add functions to load credentials from static files#8525
Merged
ZhenLian merged 4 commits intogrpc:masterfrom Sep 17, 2021
Merged
AdvancedTls: add functions to load credentials from static files#8525ZhenLian merged 4 commits intogrpc:masterfrom
ZhenLian merged 4 commits intogrpc:masterfrom
Conversation
ejona86
reviewed
Sep 16, 2021
|
|
||
| /** | ||
| * Loads the private key and certificate chains from the local file paths. The contents are only | ||
| * read at the construction time and won't be updated afterwards. |
Member
There was a problem hiding this comment.
"construction time" doesn't seem right.
| * @param keyFile the file on disk holding the private key | ||
| * @param certFile the file on disk holding the certificate chain | ||
| */ | ||
| public void loadIdentityCredentialsFromFile(File keyFile, File certFile) throws IOException, |
Member
There was a problem hiding this comment.
Seems this should also be named with "update" in its name. Update vs load isn't a useful distinction, especially since updateIdentityCredentials() is also one-shot.
ejona86
approved these changes
Sep 16, 2021
Contributor
Author
|
@ejona86 Thanks a lot for the review! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add two functions in AdvancedTls classes to load credentials from static files, making it easier to use for users who don't have the need to periodically refresh their credentials.