xds: use the correct resource id template as per xDS server gRFC#7978
xds: use the correct resource id template as per xDS server gRFC#7978sanjaypujare merged 2 commits intogrpc:masterfrom
Conversation
| } | ||
|
|
||
| @Test | ||
| public void xdsClientStart_multipleReplacements() { |
There was a problem hiding this comment.
I don't see any value of such a test, it's majorly testing the functionality of String.replaceAll(...)...
There was a problem hiding this comment.
The test verifies the contract and is useful and is not there to test functionality of replaceAll. I want the test to show breakage when implementation changes.
| } | ||
| } | ||
| String grpcServerResourceId = JsonUtil.getString(rawData, "grpc_server_resource_name_id"); | ||
| String grpcServerResourceId = |
There was a problem hiding this comment.
You should also change the property name in BoootstrapInfo and everywhere else.
There was a problem hiding this comment.
The names are really internal names between the Bootstrapper and the consumer (XdsClientWrapperForServerXds) so not strictly an API exposed to outside. But I will change it
There was a problem hiding this comment.
BTW, what name will work for you? Is serverListenerResourceNameTemplate okay?
2 participants
To match the spec in https://github.com/grpc/proposal/blob/master/A36-xds-for-servers.md#xds-protocol .