grpclb: should not ignore subchannels with CONNECTING state in aggregating the overall LB state#7959
Merged
voidzcy merged 1 commit intogrpc:masterfrom Mar 12, 2021
Conversation
ejona86
approved these changes
Mar 11, 2021
Member
ejona86
left a comment
ejona86
left a comment
There was a problem hiding this comment.
The commit message is lacking comparing to the PR description. Please include the full PR description in the commit message. Ideally you'd also mention the commit hash of Kun's commit that changed the behavior to make this appropriate.
voidzcy
force-pushed
the
bugfix/grpclb_should_not_ignore_connecting_subchannel
branch
from
c019a6c to
ede7e9a
Compare
…g the overall load balancing state. We should treat both IDLE and CONNECTING subchannels as "connection in progress" when aggregating for the overall load balancing state. Otherwise, RPCs could fail prematurely if one subchannel enters TF while all the others are still in CONNECTING. 23d2796 made each individual subchannel stay in TF until READY if it previously was in TF. So subchannels with CONNECTING state are those in first time connecting. We should give them time to connect.
voidzcy
force-pushed
the
bugfix/grpclb_should_not_ignore_connecting_subchannel
branch
from
ede7e9a to
29de6df
Compare
Contributor
|
Thanks for spotting and fixing it! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When aggregating the overall load balancing state, we should treat both IDLE and CONNECTING subchannels as "connection in progress". Otherwise, RPCs could fail prematurely if one subchannel enters TF while all the others are still in CONNECTING.
#7816 made each individual subchannel stay in TF until READY if it previously was in TF. So subchannels with CONNECTING state are those in first time connecting. We should give them time to connect.
See more comment in #7816 (comment).