DelayedTransport shutdown race#7743
Closed
YifeiZhuang wants to merge 3 commits intogrpc:masterfrom
Closed
Conversation
ejona86
force-pushed
the
delayedtransportshutdownrace
branch
from
f26a501 to
655fef2
Compare
YifeiZhuang
added a commit
that referenced
this pull request
Dec 21, 2020
YifeiZhuang
changed the title
Member
Author
|
Test |
Member
Author
|
Jump to #7749 |
dfawley
pushed a commit
to dfawley/grpc-java
that referenced
this pull request
Jan 15, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To fix #6283.
Change to be more explicit and fail fast on ClientStream calls order before and after start(), corresponding to configuration and RPC calls, respectively. This fixes the issue because it guarantees that removing from pendingStream in delayedClientTransport means it is safe to shutdown. If by the time pendingStream is processed, start() has not been called yet, nothing will drain because of the explicit strict call check, and the subsequent calls will directly execute on the realStream. This is guarded in the locking block.