Skip to content

netty: fix ENHANCE_YOUR_CALM debug data logging#6596

Merged
voidzcy merged 5 commits intogrpc:masterfrom
akandybaev:enhanceyourcalm-log-debug-data
Jan 13, 2020
Merged

netty: fix ENHANCE_YOUR_CALM debug data logging#6596
voidzcy merged 5 commits intogrpc:masterfrom
akandybaev:enhanceyourcalm-log-debug-data

Conversation

@akandybaev
Copy link
Copy Markdown
Contributor

@akandybaev akandybaev commented Jan 11, 2020

No description provided.

creamsoup
creamsoup reviewed Jan 11, 2020
View reviewed changes
Comment thread netty/src/test/java/io/grpc/netty/NettyClientHandlerTest.java Outdated
creamsoup
creamsoup approved these changes Jan 11, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@creamsoup creamsoup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 indent issues otherwise, LGTM. @voidzcy can you take a look?

Comment thread netty/src/test/java/io/grpc/netty/NettyClientHandlerTest.java Outdated
Comment thread netty/src/test/java/io/grpc/netty/NettyClientHandlerTest.java Outdated
voidzcy
voidzcy reviewed Jan 13, 2020
View reviewed changes
Comment thread netty/src/test/java/io/grpc/netty/NettyClientHandlerTest.java Outdated
@linux-foundation-easycla
Copy link
Copy Markdown

linux-foundation-easycla Bot commented Jan 13, 2020 •
edited
Loading

CLA Check
The committers are authorized under a signed CLA.

@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 13, 2020 •
edited
Loading

Codecov Report

Merging #6596 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #6596      +/-   ##
============================================
- Coverage        83%   82.99%   -0.02%     
+ Complexity     3455     3454       -1     
============================================
  Files           274      274              
  Lines         18856    18856              
  Branches       2249     2249              
============================================
- Hits          15651    15649       -2     
- Misses         2333     2337       +4     
+ Partials        872      870       -2
Impacted Files Coverage Δ Complexity Δ
...rc/main/java/io/grpc/netty/NettyClientHandler.java 89.07% <ø> (ø) 59 <0> (ø) ⬇️
...io/grpc/netty/ClientTransportLifecycleManager.java 85.71% <0%> (-3.58%) 9% <0%> (-1%)
...a/io/grpc/okhttp/ExceptionHandlingFrameWriter.java 75.25% <0%> (-2.07%) 21% <0%> (ø)
...in/java/io/grpc/okhttp/OutboundFlowController.java 91.53% <0%> (-1.54%) 25% <0%> (-1%)
...ore/src/main/java/io/grpc/internal/ServerImpl.java 86.39% <0%> (-0.26%) 30% <0%> (-1%)
...main/java/io/grpc/internal/ManagedChannelImpl.java 90.44% <0%> (-0.14%) 69% <0%> (-1%)
context/src/main/java/io/grpc/Context.java 91.33% <0%> (+0.39%) 64% <0%> (+1%) ⬆️
...ain/java/io/grpc/inprocess/InProcessTransport.java 89.48% <0%> (+0.8%) 30% <0%> (+1%) ⬆️
netty/src/main/java/io/grpc/netty/WriteQueue.java 91.66% <0%> (+1.66%) 12% <0%> (+1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 641d74f...f568eff. Read the comment docs.

@voidzcy voidzcy added the kokoro:force-run Add this label to a PR to tell Kokoro to re-run all tests. Not generally necessary label Jan 13, 2020
@grpc-kokoro grpc-kokoro removed the kokoro:force-run Add this label to a PR to tell Kokoro to re-run all tests. Not generally necessary label Jan 13, 2020
@voidzcy voidzcy merged commit 18e099d into grpc:master Jan 13, 2020
@voidzcy
Copy link
Copy Markdown
Contributor

voidzcy commented Jan 13, 2020

Thanks for contributing to grpc-java.

@akandybaev akandybaev deleted the enhanceyourcalm-log-debug-data branch January 13, 2020 23:16
@lock lock Bot locked as resolved and limited conversation to collaborators Apr 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@voidzcy voidzcy voidzcy approved these changes

@creamsoup creamsoup creamsoup approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@voidzcy voidzcy

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@akandybaev @voidzcy @creamsoup @grpc-kokoro