netty: use singleton for the custom allocator.#6526
Merged
zhangkun83 merged 1 commit intogrpc:masterfrom Dec 17, 2019
Merged
Conversation
The allocator has a circular reference that prevents it from GC'ed, thus causes memory leak if gRPC Channels are created and shutdown (even cleanly) on a regular basis. See netty/netty#6891 (comment) and internal b/146074696.
ejona86
approved these changes
Dec 17, 2019
zhangkun83
added a commit
to zhangkun83/grpc-java
that referenced
this pull request
Dec 17, 2019
Since grpc#6526 has resolved the memory leak, let's turn it back on.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The allocator has a circular reference that prevents it from GC'ed,
thus causes memory leak if gRPC Channels are created and shutdown
(even cleanly) on a regular basis.
See netty/netty#6891 (comment)
and internal b/146074696.