api: Fix javadoc for ManagedChannelBuilder#forTarget(String)#6499
Merged
ejona86 merged 2 commits intogrpc:masterfrom Dec 16, 2019
ST-DDT:adjust-javadocs
Merged
api: Fix javadoc for ManagedChannelBuilder#forTarget(String)#6499ejona86 merged 2 commits intogrpc:masterfrom ST-DDT:adjust-javadocs
ejona86 merged 2 commits intogrpc:masterfrom
ST-DDT:adjust-javadocs
Conversation
The dns scheme is only the default scheme with grpc-java. Other libraries could add more NameResolvers and thus change the default. For compatibility reasons, the schema should therefore be specified explicitly.
This was referenced Dec 8, 2019
Closed
Contributor
|
ejona86
reviewed
Dec 12, 2019
ejona86
approved these changes
Dec 16, 2019
ejona86
added
the
kokoro:run
grpc-kokoro
removed
the
kokoro:run
dapengzhang0
approved these changes
Dec 16, 2019
Member
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The dns scheme is only the default scheme with grpc-java. Other
libraries could add more NameResolvers and thus change the default. For
compatibility reasons, the schema should therefore be specified
explicitly.
The current javadocs conflict with those of
NameResolverProdiver#priority(), which allow setting a priority higher than DNS.Users of grpc-spring-boot-starter who want to use a service discovery have the problem that many libraries don't provide a schema for DNS addresses and therefore don't work anymore without additional configuration.
https://github.com/yidongnan/grpc-spring-boot-starter/issues/268
https://github.com/yidongnan/grpc-spring-boot-starter/issues/304
https://github.com/yidongnan/grpc-spring-boot-starter/issues/300