Skip to content

Upgrade to protobuf lite 3.10#6424

Merged
ejona86 merged 3 commits intogrpc:masterfrom
ejona86:lite-3.9
Nov 14, 2019
Merged

Upgrade to protobuf lite 3.10#6424
ejona86 merged 3 commits intogrpc:masterfrom
ejona86:lite-3.9

Conversation

@ejona86
Copy link
Copy Markdown
Member

@ejona86 ejona86 commented Nov 13, 2019

This finally brings lite into version number sync with full proto.


This was a change I made in September for proto 3.9. We have since upgraded to 3.10 and the commit message was no longer correct, but it seems the code didn't need to change at all. (You can see my branch name is lite-3.9 :-) )

Fixes #6405

CC @liusheng, @kiwik, @rafi-kamal, @bubenheimer

See also protocolbuffers/protobuf#6867

This finally brings lite into version number sync with full proto.
@ejona86 ejona86 requested a review from creamsoup November 13, 2019 19:22
@ejona86
Copy link
Copy Markdown
Member Author

ejona86 commented Nov 13, 2019

@creamsoup, PTAL. I needed a reasonable amount more changes for Android

Copy link
Copy Markdown
Contributor

@creamsoup creamsoup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ejona86 ejona86 merged commit 48929c4 into grpc:master Nov 14, 2019
@ejona86 ejona86 deleted the lite-3.9 branch November 14, 2019 18:26
@lock lock Bot locked as resolved and limited conversation to collaborators Feb 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Have grpc-protobuf-lite depend on protobuf-javalite, not protobuf-lite

2 participants