all: stabilize ManagedChannelBuilder.usePlaintext()#6158
all: stabilize ManagedChannelBuilder.usePlaintext()#6158dapengzhang0 merged 4 commits intogrpc:masterfrom
Conversation
| */ | ||
| @ExperimentalApi("https://github.com/grpc/grpc-java/issues/1772") | ||
| @Deprecated | ||
| public T usePlaintext(boolean skipNegotiation) { |
There was a problem hiding this comment.
There's plenty of existing users. We should leave this in-place for a good while (at least a year).
There was a problem hiding this comment.
We have already deprecated it for one and half year, still need a year?
There was a problem hiding this comment.
I think so, because it is heavily used. And it also doesn't hurt us much at all to keep it longer.
There was a problem hiding this comment.
Sure. Do you mind if I also log a WARNING in the method?
There was a problem hiding this comment.
Meh. They would already get a warning during compilation. I'd rather us not think about it much and just leave it setting there for a while.
There was a problem hiding this comment.
Sorry, I misunderstood what you said about a year and a half. Yes, that is plenty. We can remove this. Although we've also found some users that need to be migrated internally. We'll remove it once they are migrated.
| if (skipNegotiation) { | ||
| negotiationType(NegotiationType.PLAINTEXT); | ||
| } else { | ||
| negotiationType(NegotiationType.PLAINTEXT_UPGRADE); |
There was a problem hiding this comment.
I'd really like to kill NegotiationType. We may want to introduce a new method for this before deleting it.
| * @return this | ||
| * @since 1.0.0 | ||
| */ | ||
| @ExperimentalApi("https://github.com/grpc/grpc-java/issues/1772") |
There was a problem hiding this comment.
Leave the annotation. That way it is clear it can be deleted, vs a deprecated method that was stable so we can't delete it.
2 participants
Resolves #1772