api: augment CreateSubchannelArgs with custom options#5640
Merged
voidzcy merged 3 commits intogrpc:masterfrom Apr 26, 2019
Merged
Conversation
voidzcy
force-pushed
the
feature/augment_create_subchannel_args_with_options
branch
from
f71d63c to
277c00e
Compare
Contributor
|
Yes, we need to put |
voidzcy
force-pushed
the
feature/augment_create_subchannel_args_with_options
branch
from
d250b75 to
4c98c4a
Compare
zhangkun83
approved these changes
Apr 26, 2019
Member
|
LoadBalancer.Key may prove a bit weird, but we'll see where it goes. |
Contributor
|
It's actually |
Member
|
Oh, good. I see it now. I just followed the indentation/braces wrong. |
This was referenced Apr 29, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@zhangkun83 Do we write test for this? Also, do we need a api tracking issue?