core: add LoadBalancer.Helper#createResolvingOobChannel()#5415
Merged
zhangkun83 merged 2 commits intogrpc:masterfrom Mar 4, 2019
Merged
core: add LoadBalancer.Helper#createResolvingOobChannel()#5415zhangkun83 merged 2 commits intogrpc:masterfrom
zhangkun83 merged 2 commits intogrpc:masterfrom
Conversation
This can be used by xds LoadBalancer to create a channel to the XDS traffic director, as the service config will only specify the target name of the balancer. This PR only adds the interface to unblock the xds work. Implementation would take some time thus will come later.
dapengzhang0
approved these changes
Mar 1, 2019
Contributor
dapengzhang0
left a comment
dapengzhang0
left a comment
There was a problem hiding this comment.
LGTM with minor comments
| * | ||
| * <p>The target string will be resolved by a {@link NameResolver} created according to the | ||
| * target string. The out-of-band channel doesn't have load-balancing. If multiple addresses | ||
| * are resolved for the target, the "pick_first" policy will be applied. |
Contributor
There was a problem hiding this comment.
the "pick_first" policy will be applied seems implementation detail, or an instruction for implementors, but the users don't care what's under the hood.
Contributor
Author
There was a problem hiding this comment.
Fair. I changed it to a descriptive phrasing.
| * | ||
| * <P>NOT IMPLEMENTED: this method is currently a stub and not yet implemented by gRPC. | ||
| */ | ||
| public ManagedChannel createResolvingOobChannel(String target) { |
Contributor
There was a problem hiding this comment.
I'm not against a slight different name, but "createResolvingOobChannel" may not be better than "createOobChannel".
ejona86
approved these changes
Mar 2, 2019
dapengzhang0
reviewed
Mar 2, 2019
| * channels within {@link #shutdown}. | ||
| * | ||
| * <P>NOT IMPLEMENTED: this method is currently a stub and not yet implemented by gRPC. | ||
| */ |
dapengzhang0
approved these changes
Mar 4, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This can be used by xds LoadBalancer to create a channel to the XDS
traffic director, as the service config will only specify the target
name of the balancer.
This PR only adds the interface to unblock the xds work.
Implementation would take some time thus will come later.
I selected a slightly different name from the original
createOobChannel()to signify their difference. I am open to naming it just
createOobChannel().