java_grpc_library: re-add grpc-java repo to targets (1.11 backport)#4463
Merged
ejona86 merged 1 commit intogrpc:v1.11.xfrom May 14, 2018
Merged
java_grpc_library: re-add grpc-java repo to targets (1.11 backport)#4463ejona86 merged 1 commit intogrpc:v1.11.xfrom
ejona86 merged 1 commit intogrpc:v1.11.xfrom
Conversation
They were removed in 137c74d since it was believed they were unnecessary. However, since they are in a macro and not a rule, they are relative to the caller, not their definition. Added building the examples to the kokoro CI. Note that this means the examples are built twice: once in grpc-java's build and once in their own (because it has a WORKSPACE). Given that the Bazel build is our fastest build, this slowdown won't probably be an issue.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
They were removed in 137c74d since it was believed they were unnecessary.
However, since they are in a macro and not a rule, they are relative to the
caller, not their definition.
Added building the examples to the kokoro CI. Note that this means the examples
are built twice: once in grpc-java's build and once in their own (because it
has a WORKSPACE). Given that the Bazel build is our fastest build, this
slowdown won't probably be an issue.
CC @carl-mastrangelo
This is a backport of #4288