java_grpc_library: re-add grpc-java repo to targets#4288
Merged
ejona86 merged 1 commit intogrpc:masterfrom Apr 3, 2018
Merged
Conversation
They were removed in 137c74d since it was believed they were unnecessary. However, since they are in a macro and not a rule, they are relative to the caller, not their definition. Added building the examples to the kokoro CI. Note that this means the examples are built twice: once in grpc-java's build and once in their own (because it has a WORKSPACE). Given that the Bazel build is our fastest build, this slowdown won't probably be an issue.
Contributor
|
Mmm.. what you're saying makes sense, but I removed the repo name because it unbroke my build. But perhaps I mixed things up and it wasn't actually my problem. |
Member
Author
|
@cgrushko, there was one instance I didn't revert, because it was in the rule() instead. That did behave like you were saying, so I didn't need to put the repo prefix. I'm working on a version that uses java_common to fix the long-standing stict_dep issues, which will make all of this move into the rule. I still have to work out a problem with android, but I think I'll use java_import for that. Hopefully this change will become moot soon. |
ejona86
requested review from
carl-mastrangelo
and removed request for
dapengzhang0
carl-mastrangelo
approved these changes
Apr 3, 2018
Contributor
carl-mastrangelo
left a comment
carl-mastrangelo
left a comment
There was a problem hiding this comment.
No concerns here. LGTM
Contributor
|
@ejona86 is this going to backport to v1.11.x? |
Member
Author
|
Backporting in #4463 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
They were removed in 137c74d since it was believed they were unnecessary.
However, since they are in a macro and not a rule, they are relative to the
caller, not their definition.
Added building the examples to the kokoro CI. Note that this means the examples
are built twice: once in grpc-java's build and once in their own (because it
has a WORKSPACE). Given that the Bazel build is our fastest build, this
slowdown won't probably be an issue.
CC @cgrushko