okhttp: Convert to internal ConnectionSpec eagerly#4267
Merged
ejona86 merged 2 commits intogrpc:masterfrom Mar 26, 2018
Merged
Conversation
This allows ProGuard to remove OkHttp's ConnectionSpec in most cases, saving about 40 methods.
Member
Author
|
@ericgribkoff, so the DEFAULT_CONNECTION_SPEC is public. That makes it a bit unclear on what to do. It may be best to just give up on this particular detail. |
Contributor
|
Not sure what to do here, unless we can deprecate |
Member
Author
|
@ericgribkoff, made the change as we discussed. PTAL |
ericgribkoff
approved these changes
Mar 26, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows ProGuard to remove OkHttp's ConnectionSpec in most cases,
saving about 40 methods. The savings won't be realized until
DEFAULT_CONNECTION_SPEC is removed.