Migrating run scripts to gradle.#39
Migrating run scripts to gradle.#39nmittler wants to merge 1 commit intogrpc:masterfrom nmittler:run_with_gradle
Conversation
There was a problem hiding this comment.
Happens in every file.
|
@ejona86 this does most of the heavy lifting toward getting rid of Maven. We now run the client and server via gradle. A few other adds as well for using the animal sniffer and compiler arguments. |
There was a problem hiding this comment.
You can reference JavaVersion without the FQCN (which means you might want to inline these into the if)
|
Just submitted a few changes to address comments. |
There was a problem hiding this comment.
I think this is now obsolete, since we deleted the code already (grpc v1).
|
LGTM. :integration-testing:execute is the main thing I'd hope was fixed before pushing. |
There was a problem hiding this comment.
The buildDir property is already a File, no need to wrap.
|
@JakeWharton @ejona86 Just pushed some more changes ... take a look and see if everything has been addressed. |
|
LGTM |
|
@JakeWharton any other comments or shall I cherry-pick? |
|
Nope. LGTM. Was just drive-by reviewing :) |
|
Submitted as 02c953e |
|
:) thanks for the review! |
4 participants
No description provided.