11243: RLS cleanups #12085
Merged
11243: RLS cleanups #12085
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ejona86
reviewed
May 27, 2025
vimanikag
force-pushed
the
vimanikag-FIX_11243_RLS
branch
from
44a715f to
8974a30
Compare
…manikag-FIX_11243_RLS # Conflicts: # rls/src/main/java/io/grpc/rls/LinkedHashLruCache.java
ejona86
reviewed
Jun 18, 2025
vimanikag
commented
Jun 18, 2025
ejona86
added
the
kokoro:run
grpc-kokoro
removed
the
kokoro:run
ejona86
approved these changes
Jun 23, 2025
Member
ejona86
left a comment
ejona86
left a comment
There was a problem hiding this comment.
In CachingRlsLbClient, shouldInvalidateEldestEntry() is managed based on time, as we make sure an entry is not too new. But this is valid, even if it is misleading on how the class is intended to be used.
| @Test | ||
| public void testFitToLimitWithReSize() { | ||
|
|
||
| Entry entry1 = new Entry("Entry1", ticker.read() + 10,4); |
Member
There was a problem hiding this comment.
Add space after comma (ditto in next test)
Contributor
Author
There was a problem hiding this comment.
Addressed the review comments
| assertThat(localCache.fitToLimit()).isEqualTo(true); | ||
|
|
||
| assertThat(localCache.values().contains(entry1)).isFalse(); | ||
| assertThat(localCache.values().containsAll(Arrays.asList(entry2,entry3))).isTrue(); |
Contributor
Author
There was a problem hiding this comment.
Addressed the review comments
shivaspeaks
approved these changes
Jun 24, 2025
Member
shivaspeaks
left a comment
shivaspeaks
left a comment
There was a problem hiding this comment.
Merge branch master into your branch to include #12169 so that your Linux artifacts Kokoro build passes.
ejona86
added
the
kokoro:run
grpc-kokoro
removed
the
kokoro:run
jdcormie
pushed a commit
to jdcormie/grpc-java
that referenced
this pull request
Jun 27, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
addressed the review comments provided on #11243
Fixes : #11243