services: fix HealthService notifyWatchers #11934
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
JoeCqupt
commented
Mar 5, 2025
services/src/main/java/io/grpc/protobuf/services/HealthServiceImpl.java
Outdated
Show resolved
Hide resolved
JoeCqupt
changed the title
ejona86
reviewed
Mar 20, 2025
Member
ejona86
left a comment
ejona86
left a comment
There was a problem hiding this comment.
I don't think we want to catch the exception. I think we want to avoid the exception by using setOnCancelHandler() as mentioned in the error to update watchers. That will release resources as soon as the RPC is cancelled.
ejona86
approved these changes
Mar 21, 2025
ejona86
added
the
kokoro:run
grpc-kokoro
removed
the
kokoro:run
kannanjgithub
approved these changes
Mar 25, 2025
Member
|
@JoeCqupt, thank you! |
Sangamesh1997
pushed a commit
to Sangamesh1997/grpc-java
that referenced
this pull request
Apr 3, 2025
…already have their connections cancelled (grpc#11934) Some clients watching health status can cancel their watch and `HealthService` when trying to notify these watchers were getting CANCELLED exception because there was no cancellation handler set on the `StreamObserver`. This change sets the cancellation handler that removes the watcher from the set of watcher clients to be notified of the health status.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #11853
Use ServerCallStreamObserver.setOnCancelHandler() to disable this exception