Skip to content

core: logging the error message when onClose() itself fails #11880

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
shivaspeaks merged 8 commits into from
Feb 11, 2025
Merged

core: logging the error message when onClose() itself fails #11880

shivaspeaks merged 8 commits into from
Feb 11, 2025

Conversation

@NaveenPrasannaV
Copy link
Contributor

@NaveenPrasannaV NaveenPrasannaV commented Feb 4, 2025 •
edited by shivaspeaks
Loading

Fixes #6092

@NaveenPrasannaV NaveenPrasannaV marked this pull request as ready for review February 4, 2025 11:14
@vinodhabib
Copy link
Contributor

vinodhabib commented Feb 5, 2025

@shivaspeaks This PR is Ready for your Review. Request you to have a look once.

shivaspeaks
shivaspeaks reviewed Feb 6, 2025
View reviewed changes
@shivaspeaks shivaspeaks added the kokoro:run Add this label to a PR to tell Kokoro the code is safe and tests can be run label Feb 6, 2025
@grpc-kokoro grpc-kokoro removed the kokoro:run Add this label to a PR to tell Kokoro the code is safe and tests can be run label Feb 6, 2025
@ejona86 ejona86 added the kokoro:run Add this label to a PR to tell Kokoro the code is safe and tests can be run label Feb 8, 2025
@grpc-kokoro grpc-kokoro removed the kokoro:run Add this label to a PR to tell Kokoro the code is safe and tests can be run label Feb 8, 2025
@shivaspeaks shivaspeaks added the kokoro:run Add this label to a PR to tell Kokoro the code is safe and tests can be run label Feb 11, 2025
@shivaspeaks shivaspeaks changed the title core: added try catch block for onClose() with logging the error message core: logging the error message when onClose() itself fails Feb 11, 2025
@shivaspeaks shivaspeaks merged commit 302342c into grpc:master Feb 11, 2025
16 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 13, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@ejona86 ejona86 ejona86 approved these changes

@shivaspeaks shivaspeaks shivaspeaks approved these changes

@kannanjgithub kannanjgithub Awaiting requested review from kannanjgithub

+1 more reviewer

@larry-safran larry-safran larry-safran approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

kokoro:run Add this label to a PR to tell Kokoro the code is safe and tests can be run

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Unary call can hang forever if uncaught exeception thrown in client interceptor

6 participants

@NaveenPrasannaV @vinodhabib @ejona86 @shivaspeaks @larry-safran @grpc-kokoro