Skip to content

xds: fixed unsupported unsigned 32 bits issue for circuit breaker #11735

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ejona86 merged 4 commits into from
Dec 17, 2024
Merged

xds: fixed unsupported unsigned 32 bits issue for circuit breaker #11735

ejona86 merged 4 commits into from
Dec 17, 2024

Conversation

@vinodhabib
Copy link
Contributor

@vinodhabib vinodhabib commented Dec 10, 2024 •
edited
Loading

Added change for circuit breaking by converting signed 32-bit Int to Unsigned 64-bit Long For MaxRequest negative value ( -1)

Fixes #11695

@vinodhabib vinodhabib marked this pull request as ready for review December 12, 2024 06:47
@vinodhabib vinodhabib marked this pull request as draft December 12, 2024 07:15
@vinodhabib vinodhabib marked this pull request as ready for review December 12, 2024 10:22
@ejona86 ejona86 added kokoro:run Add this label to a PR to tell Kokoro the code is safe and tests can be run TODO:backport PR needs to be backported. Removed after backport complete labels Dec 17, 2024
@grpc-kokoro grpc-kokoro removed the kokoro:run Add this label to a PR to tell Kokoro the code is safe and tests can be run label Dec 17, 2024
@ejona86 ejona86 merged commit f8f6139 into grpc:master Dec 17, 2024
16 checks passed
@vinodhabib vinodhabib deleted the defect-11695-CB-support-change branch December 18, 2024 07:08
ejona86 pushed a commit to ejona86/grpc-java that referenced this pull request Jan 15, 2025
@vinodhabib @ejona86
xds: fixed unsupported unsigned 32 bits issue for circuit breaker (gr…
d878c56 
…pc#11735)

Added change for circuit breaking by converting signed 32-bit Int to Unsigned 64-bit Long For MaxRequest negative value ( -1)

Fixes grpc#11695
ejona86 pushed a commit to ejona86/grpc-java that referenced this pull request Jan 15, 2025
@vinodhabib @ejona86
xds: fixed unsupported unsigned 32 bits issue for circuit breaker (gr…
1ceb99f 
…pc#11735)

Added change for circuit breaking by converting signed 32-bit Int to Unsigned 64-bit Long For MaxRequest negative value ( -1)

Fixes grpc#11695
This was referenced Jan 15, 2025
Merged
Merged
ejona86 pushed a commit that referenced this pull request Jan 15, 2025
@vinodhabib @ejona86
xds: fixed unsupported unsigned 32 bits issue for circuit breaker (#1…
bccbb8b 
…1735)

Added change for circuit breaking by converting signed 32-bit Int to Unsigned 64-bit Long For MaxRequest negative value ( -1)

Fixes #11695
ejona86 pushed a commit that referenced this pull request Jan 15, 2025
@vinodhabib @ejona86
xds: fixed unsupported unsigned 32 bits issue for circuit breaker (#1…
112dccb 
…1735)

Added change for circuit breaking by converting signed 32-bit Int to Unsigned 64-bit Long For MaxRequest negative value ( -1)

Fixes #11695
@ejona86 ejona86 removed the TODO:backport PR needs to be backported. Removed after backport complete label Jan 16, 2025
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 17, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@ejona86 ejona86 ejona86 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

xds: Circuit breaking doesn't support unsigned 32 bits

3 participants

@vinodhabib @ejona86 @grpc-kokoro