Update protobuf-java to address CVE-2024-7254#11543
Merged
ejona86 merged 1 commit intogrpc:masterfrom Sep 24, 2024
Merged
Conversation
Signed-off-by: Mark S. Lewis <[email protected]>
bestbeforetoday
force-pushed
the
CVE-2024-7254
branch
from
2b899e1 to
351967d
Compare
Contributor
Author
|
I don't know how anything I have changed would have caused a failure for Java 11 and not for Java 8 or Java 17. I suspect this is a test flake. Any guidance is appreciated. |
ejona86
added
the
kokoro:run
grpc-kokoro
removed
the
kokoro:run
ejona86
approved these changes
Sep 20, 2024
Member
ejona86
left a comment
ejona86
left a comment
There was a problem hiding this comment.
I'll note this doesn't upgrade Bazel. That must be acceptable for bzlmod as BCR doesn't have a 25.x version. We could update non-bzlmod by updating repositories.bzl, but external contributors generally don't have Bazel.
Member
|
The Java 11 error was for grpc-servlet, and yes, unfortunately that is flaky. Seems Macos failed due to a download failure. I've restarted both of them. |
kannanjgithub
approved these changes
Sep 24, 2024
ejona86
added
the
TODO:backport
2 tasks
ejona86
removed
the
TODO:backport
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #11542