Skip to content

okhttp: Ignore known conscrypt socket close issue#10811

Merged
temawi merged 2 commits intogrpc:masterfrom
temawi:binder-socket-close-fix
Jan 10, 2024
Merged

okhttp: Ignore known conscrypt socket close issue#10811
temawi merged 2 commits intogrpc:masterfrom
temawi:binder-socket-close-fix

Conversation

@temawi
Copy link
Copy Markdown
Contributor

@temawi temawi commented Jan 10, 2024

This stops an exception from being thrown when a known Conscrypt synchronization issue happens.

Note that lack of coverage on the PR is because this issue only happens infrequently in highly concurrent systems and a unit test would not be able to catch it.

Fixes: #10800

@temawi temawi requested a review from ejona86 January 10, 2024 18:12
@temawi temawi merged commit 6605649 into grpc:master Jan 10, 2024
@temawi temawi deleted the binder-socket-close-fix branch January 10, 2024 19:01
temawi added a commit to temawi/grpc-java that referenced this pull request Jan 10, 2024
This stops an exception from being thrown when a known Conscrypt synchronization issue happens.
temawi added a commit that referenced this pull request Jan 10, 2024
This stops an exception from being thrown when a known Conscrypt synchronization issue happens.
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Apr 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unhandled java.lang.NullPointerException: bio == null in io.grpc.okhttp.internal.framed.Http2$Reader.close

2 participants