If certain methods are useful, have a reasonable API, and are maintainable, we can keep them.

@trustin, details about your test:

It is not using GrpcSslContexts. It can override trustManager after configuring the SslContext via GrpcSslContexts, but it should pass through GrpcSslContexts.
preferredTestCiphers() really should have been internal. Although you are using it the same as we are (testing OkHttp on the JDK). This was needed when the JDK's GCM went at 2 MB/s. Now it's 10x that and JDK 9 will be 10x again. So maybe we just drop it. Alternatively we can kill it in favor of Conscrypt. It is only helpful with Jetty ALPN. Conscrypt is very close to 1.0 with pre-built binaries for multiple platforms. But OkHttp will need some fixes to make use of it off-Android.
The usage of newSslSocketFactoryForCa is coupled with a usage of io.grpc.okhttp.internal.Platform. That's obviously not supported. But I understand the need.
There's a usage of GrpcUtil.authorityFromHostAndPort which is also internal. It could have been just "example.com:" + port. A big reason for the utility is to handle IPv6 IPs which need []. That's unnecessary in the test

I'm fine to work out utility functions for using test certificates. I understand that is a major PITA and using grpc's pre-generated test certs makes things much easier. But I expect they could be simplified.

For example, Netty now has InputStream-based methods for some of these things. loadCert() could actually just return an InputStream. That means loadX509Cert is probably unnecessary now-a-days.

Functionality that looks good to keep (but maybe renamed/moved/tweaked):

One-line impl for InputStream loadCert(String name)
newSslSocketFactoryForCa() it is useful for OkHttp, but... providing Provider is a problem. Maybe we can add a method to OkHttpChannelBuilder. Maybe trustManagerFactory(TrustManagerFactory) (+ testing utility) or trustCertificates(InputStream) that is used when we create our SSLContext. That would avoid needing to specify a Provider.

Tracking Issue for Testing utilities being Experimental. #1791

Description

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions