cronet: CronetChannelBuilder extends a public API class

sergiitk · sergiitk · commit c92aa67c86fb · 2020-08-25T17:28:40.000-04:00
diff --git a/cronet/src/main/java/io/grpc/cronet/CronetChannelBuilder.java b/cronet/src/main/java/io/grpc/cronet/CronetChannelBuilder.java
@@ -26,10 +26,14 @@
 import com.google.common.util.concurrent.MoreExecutors;
 import io.grpc.ChannelLogger;
 import io.grpc.ExperimentalApi;
-import io.grpc.internal.AbstractManagedChannelImplBuilder;
+import io.grpc.ForwardingChannelBuilder;
+import io.grpc.Internal;
+import io.grpc.ManagedChannelBuilder;
 import io.grpc.internal.ClientTransportFactory;
 import io.grpc.internal.ConnectionClientTransport;
 import io.grpc.internal.GrpcUtil;
+import io.grpc.internal.ManagedChannelImplBuilder;
+import io.grpc.internal.ManagedChannelImplBuilder.ClientTransportFactoryBuilder;
 import io.grpc.internal.SharedResourceHolder;
 import io.grpc.internal.TransportTracer;
 import java.lang.reflect.InvocationTargetException;
@@ -46,8 +50,7 @@
 
 /** Convenience class for building channels with the cronet transport. */
 @ExperimentalApi("There is no plan to make this API stable, given transport API instability")
-public final class CronetChannelBuilder extends
-    AbstractManagedChannelImplBuilder<CronetChannelBuilder> {
+public final class CronetChannelBuilder extends ForwardingChannelBuilder<CronetChannelBuilder> {
 
   private static final String LOG_TAG = "CronetChannelBuilder";
 
@@ -81,6 +84,8 @@ public static CronetChannelBuilder forAddress(String name, int port) {
   private ScheduledExecutorService scheduledExecutorService;
 
   private final CronetEngine cronetEngine;
+  private final ManagedChannelImplBuilder managedChannelImplBuilder;
+  private TransportTracer.Factory transportTracerFactory = TransportTracer.getDefaultFactory();
 
   private boolean alwaysUsePut = false;
 
@@ -103,12 +108,30 @@ public static CronetChannelBuilder forAddress(String name, int port) {
   private int trafficStatsUid;
 
   private CronetChannelBuilder(String host, int port, CronetEngine cronetEngine) {
-    super(
+    super();
+
+    // An anonymous class to inject client transport factory builder.
+    final class CronetChannelTransportFactoryBuilder implements ClientTransportFactoryBuilder {
+      @Override
+      public ClientTransportFactory buildClientTransportFactory() {
+        return buildTransportFactory();
+      }
+    }
+
+    managedChannelImplBuilder = new ManagedChannelImplBuilder(
         InetSocketAddress.createUnresolved(host, port),
-        GrpcUtil.authorityFromHostAndPort(host, port));
+        GrpcUtil.authorityFromHostAndPort(host, port),
+        new CronetChannelTransportFactoryBuilder(),
+        null);
     this.cronetEngine = Preconditions.checkNotNull(cronetEngine, "cronetEngine");
   }
 
+  @Internal
+  @Override
+  protected ManagedChannelBuilder<?> delegate() {
+    return managedChannelImplBuilder;
+  }
+
   /**
    * Sets the maximum message size allowed to be received on the channel. If not called,
    * defaults to {@link io.grpc.internal.GrpcUtil#DEFAULT_MAX_MESSAGE_SIZE}.
@@ -188,8 +211,7 @@ public final CronetChannelBuilder scheduledExecutorService(
     return this;
   }
 
-  @Override
-  protected final ClientTransportFactory buildTransportFactory() {
+  final ClientTransportFactory buildTransportFactory() {
     return new CronetTransportFactory(
         new TaggingStreamFactory(
             cronetEngine, trafficStatsTagSet, trafficStatsTag, trafficStatsUidSet, trafficStatsUid),
