Add GuardedBy suppressions to CronetClientTransport

graememorgan · web-flow · commit 448d5f17d916 · 2019-12-21T21:15:11.000Z
diff --git a/cronet/src/main/java/io/grpc/cronet/CronetClientTransport.java b/cronet/src/main/java/io/grpc/cronet/CronetClientTransport.java
@@ -149,9 +149,12 @@ public void run() {
     return new StartCallback().clientStream;
   }
 
+  @SuppressWarnings("GuardedBy")
   @GuardedBy("lock")
   private void startStream(CronetClientStream stream) {
     streams.add(stream);
+    // TODO(b/145386688): This access should be guarded by 'stream.transportState().lock'; instead
+    // found: 'this.lock'
     stream.transportState().start(streamFactory);
   }
 

Original file line number	Diff line number	Diff line change
`@@ -149,9 +149,12 @@ public void run() {`
`149`	`149`	`return new StartCallback().clientStream;`
`150`	`150`	`}`
`151`	`151`
	`152`	`+ @SuppressWarnings("GuardedBy")`
`152`	`153`	`@GuardedBy("lock")`
`153`	`154`	`private void startStream(CronetClientStream stream) {`
`154`	`155`	`streams.add(stream);`
	`156`	`+ // TODO(b/145386688): This access should be guarded by 'stream.transportState().lock'; instead`
	`157`	`+ // found: 'this.lock'`
`155`	`158`	`stream.transportState().start(streamFactory);`
`156`	`159`	`}`
`157`	`160`