Invert if statement in ProtoUtil to improve readability.

rmehta19 · rmehta19 · commit 08f83421b3ec · 2024-09-12T09:45:50.000-07:00
diff --git a/s2a/src/main/java/io/grpc/s2a/handshaker/ProtoUtil.java b/s2a/src/main/java/io/grpc/s2a/handshaker/ProtoUtil.java
@@ -84,10 +84,10 @@ static ImmutableSet<String> buildTlsProtocolVersionSet(
       } catch (IllegalArgumentException e) {
         continue;
       }
-      if (versionNumber < minTlsVersion.getNumber() || versionNumber > maxTlsVersion.getNumber()) {
-        continue;
+      if (versionNumber >= minTlsVersion.getNumber()
+          && versionNumber <= maxTlsVersion.getNumber()) {
+        tlsVersions.add(convertTlsProtocolVersion(tlsVersion));
       }
-      tlsVersions.add(convertTlsProtocolVersion(tlsVersion));
     }
     return tlsVersions.build();
   }

Original file line number	Diff line number	Diff line change
`@@ -84,10 +84,10 @@ static ImmutableSet<String> buildTlsProtocolVersionSet(`
`84`	`84`	`} catch (IllegalArgumentException e) {`
`85`	`85`	`continue;`
`86`	`86`	`}`
`87`		`- if (versionNumber < minTlsVersion.getNumber() \|\| versionNumber > maxTlsVersion.getNumber()) {`
`88`		`- continue;`
	`87`	`+ if (versionNumber >= minTlsVersion.getNumber()`
	`88`	`+ && versionNumber <= maxTlsVersion.getNumber()) {`
	`89`	`+ tlsVersions.add(convertTlsProtocolVersion(tlsVersion));`
`89`	`90`	`}`
`90`		`- tlsVersions.add(convertTlsProtocolVersion(tlsVersion));`
`91`	`91`	`}`
`92`	`92`	`return tlsVersions.build();`
`93`	`93`	`}`