stats/opentelemetry/csm: Get mesh_id local label from "CSM_MESH_ID" environment variable, rather than parsing from bootstrap file#7740
Merged
zasweq merged 1 commit intogrpc:masterfrom Oct 15, 2024
Conversation
…from bootstrap file
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7740 +/- ##
==========================================
+ Coverage 82.07% 82.09% +0.02%
==========================================
Files 362 362
Lines 28116 28116
==========================================
+ Hits 23075 23081 +6
- Misses 3839 3842 +3
+ Partials 1202 1193 -9 |
Contributor
Not fully familiar with the background on this but for now should we keep both parsing from bootstrap and env var for backward compatibility? |
Contributor
Author
|
No not in this case, as we are getting rid of the old way entirely. |
dfawley
approved these changes
Oct 15, 2024
Contributor
Author
|
Interop tests passed. |
sagarsudo
pushed a commit
to sagarsudo/grpc-go
that referenced
this pull request
Oct 16, 2024
…environment variable, rather than parsing from bootstrap file (grpc#7740)
16 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR switches the mesh_id local label to get set from the CSM_MESH_ID environment variable, with the same logic as other labels set from the environment. It no longer comes from the bootstrap, or needs to be parsed from the node_id of the bootstrap.
RELEASE NOTES: