Skip to content

deps: remove dependency of github.com/golang/protobuf from main module#7122

Merged
arvindbr8 merged 3 commits intogrpc:masterfrom
arvindbr8:dep_github_protobuf
Apr 11, 2024
Merged

deps: remove dependency of github.com/golang/protobuf from main module#7122
arvindbr8 merged 3 commits intogrpc:masterfrom
arvindbr8:dep_github_protobuf

Conversation

@arvindbr8
Copy link
Copy Markdown
Contributor

@arvindbr8 arvindbr8 commented Apr 11, 2024

Should be the last piece which fixes #5316 to nth degree. There is an indirect dependency on the package which can only be removed when our other dependencies remove the transitive dependency on github.com/golang/protobuf

RELEASE NOTES:

  • deps: remove dependency on github.com/golang/protobuf

Comment thread reflection/internal/internal.go
Comment thread reflection/internal/internal.go
Comment thread reflection/internal/internal.go
Copy link
Copy Markdown
Contributor Author

@arvindbr8 arvindbr8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. :)

Comment thread reflection/internal/internal.go
Comment thread reflection/internal/internal.go
Comment thread reflection/internal/internal.go
@arvindbr8 arvindbr8 requested a review from dfawley April 11, 2024 21:04
@arvindbr8 arvindbr8 added the Type: Dependencies Updating/adding/removing dependencies label Apr 11, 2024
@arvindbr8 arvindbr8 added this to the 1.64 Release milestone Apr 11, 2024
@arvindbr8 arvindbr8 linked an issue Apr 11, 2024 that may be closed by this pull request
@arvindbr8 arvindbr8 merged commit a4afd4d into grpc:master Apr 11, 2024
@arvindbr8 arvindbr8 deleted the dep_github_protobuf branch April 11, 2024 21:35
@ash2k
Copy link
Copy Markdown
Contributor

ash2k commented Apr 11, 2024

Happy to see this! Thank you!

@Clement-Jean
Copy link
Copy Markdown
Contributor

Good job @arvindbr8 !

@arvindbr8 arvindbr8 mentioned this pull request Apr 17, 2024
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Oct 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Type: Dependencies Updating/adding/removing dependencies

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update proto package imports to google.golang.org/protobuf/proto

4 participants