deps: move from github.com/golang/protobuf to google.golang.org/protobuf/proto#6919
deps: move from github.com/golang/protobuf to google.golang.org/protobuf/proto#6919arvindbr8 merged 37 commits intogrpc:masterfrom Clement-Jean:remove_old_proto_pkg
Conversation
d.CheckValid() already does the nil check Co-authored-by: Arvind Bright <[email protected]>
d.CheckValid() already does the nil check Co-authored-by: Arvind Bright <[email protected]>
|
@dfawley please check this PR. It might need another code review just to be sure that after merging with the new updates, it is still ok. |
|
The remaining mention to github.com/golang/protobuf seems to be indirect dependency, some mentions in scripts and channelz. Could you take a look at the changes? especially in reflection/grpc_testing_not_regenerate, I'm not sure if it is correct. I splitted the testv3.go into two files (pb and grpc) but if you need to merge them let me know. |
|
Would you mind reverting all those changes since the last review so we can submit the already-reviewed code without delay? You can move them into another branch and we can go from there. Thanks! |
|
@dfawley This should be reverted |
arvindbr8
left a comment
arvindbr8
left a comment
There was a problem hiding this comment.
LGTM, Thanks @Clement-Jean
arvindbr8
changed the title
|
Hi, I don't know whether there is a third phase planned to this task, but in my application there is one remaining place where i see the deprecated dependency being brought in. Credentials.go in google.golang.org/grpc/credentials ( grpc-go/credentials/credentials.go Line 31 in 5ccf176 |
|
@RJKeevil We cannot remove that just yet because of possible conflicts due to a rewrite. However it's planned and I will work on it ASAP 😊 |
|
Yes, I think we're all clear now to finish it. Unfortunately, it looks like we'll still keep the dependency in perpetuity because of testing in https://github.com/grpc/grpc-go/blob/cce163274b6cb9de2b2bf0bc742384e5755fee42/reflection/grpc_testing_not_regenerate/testv3.go#L41C9-L41C41 |
…egeneratable proto code into /testdata (#7724)
…on-regeneratable proto code into /testdata (grpc#7724)
…on-regeneratable proto code into /testdata (grpc#7724)
…on-regeneratable proto code into /testdata (grpc#7724)
6 participants
This is the second part of #6736 which is moving away from github.com/golang/protobuf in favor of google.golang.org/protobuf/proto
RELEASE NOTES: