Avoid int32 overflow when applying initial window size setting

ahmadsherif · mehrdada · commit a8cd0c13a447 · 2017-06-01T12:36:46.000-07:00
diff --git a/transport/http2_client.go b/transport/http2_client.go
@@ -1166,7 +1166,7 @@ func (t *http2Client) applySettings(ss []http2.Setting) {
 			t.mu.Lock()
 			for _, stream := range t.activeStreams {
 				// Adjust the sending quota for each stream.
-				stream.sendQuotaPool.add(int(s.Val - t.streamSendQuota))
+				stream.sendQuotaPool.add(int(s.Val) - int(t.streamSendQuota))
 			}
 			t.streamSendQuota = s.Val
 			t.mu.Unlock()
diff --git a/transport/http2_server.go b/transport/http2_server.go
@@ -875,7 +875,7 @@ func (t *http2Server) applySettings(ss []http2.Setting) {
 			t.mu.Lock()
 			defer t.mu.Unlock()
 			for _, stream := range t.activeStreams {
-				stream.sendQuotaPool.add(int(s.Val - t.streamSendQuota))
+				stream.sendQuotaPool.add(int(s.Val) - int(t.streamSendQuota))
 			}
 			t.streamSendQuota = s.Val
 		}

Original file line number	Diff line number	Diff line change
`@@ -1166,7 +1166,7 @@ func (t *http2Client) applySettings(ss []http2.Setting) {`
`1166`	`1166`	`t.mu.Lock()`
`1167`	`1167`	`for _, stream := range t.activeStreams {`
`1168`	`1168`	`// Adjust the sending quota for each stream.`
`1169`		`- stream.sendQuotaPool.add(int(s.Val - t.streamSendQuota))`
	`1169`	`+ stream.sendQuotaPool.add(int(s.Val) - int(t.streamSendQuota))`
`1170`	`1170`	`}`
`1171`	`1171`	`t.streamSendQuota = s.Val`
`1172`	`1172`	`t.mu.Unlock()`
Original file line number	Diff line number	Diff line change
`@@ -875,7 +875,7 @@ func (t *http2Server) applySettings(ss []http2.Setting) {`
`875`	`875`	`t.mu.Lock()`
`876`	`876`	`defer t.mu.Unlock()`
`877`	`877`	`for _, stream := range t.activeStreams {`
`878`		`- stream.sendQuotaPool.add(int(s.Val - t.streamSendQuota))`
	`878`	`+ stream.sendQuotaPool.add(int(s.Val) - int(t.streamSendQuota))`
`879`	`879`	`}`
`880`	`880`	`t.streamSendQuota = s.Val`
`881`	`881`	`}`