Adds MapGrpcService overload for ServerServiceDefinition#2535
Closed
aka-nse wants to merge 1039 commits into
Closed
Adds MapGrpcService overload for ServerServiceDefinition#2535aka-nse wants to merge 1039 commits into
aka-nse wants to merge 1039 commits into
Conversation
…ot (#1909) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
#1911) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
#1910) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Update version to 2.50.0-pre1 (on v2.50.x branch) * Update VersionInfo.cs
…#1957) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
#1958) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…ServerServiceDefinition (#1) * support MapGrpcService with ServerServiceDefinition * support MapGrpcService with ServerServiceDefinition * rename sample solution file * create factory method * remove extra using * fix sample project for ServerServiceDefinition mapping * implement Metadata creation for ServerServiceDefinition * implement unit test for MapGrpcService for ServerServiceDefinition --------- Co-authored-by: aka-nse <[email protected]>
…ntApp (#2536) Bumps [serve-static](https://github.com/expressjs/serve-static) from 1.14.2 to 1.16.2. - [Release notes](https://github.com/expressjs/serve-static/releases) - [Changelog](https://github.com/expressjs/serve-static/blob/v1.16.2/HISTORY.md) - [Commits](expressjs/serve-static@v1.14.2...v1.16.2) --- updated-dependencies: - dependency-name: serve-static dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…2567) Bumps [elliptic](https://github.com/indutny/elliptic) from 6.5.7 to 6.6.0. - [Commits](indutny/elliptic@v6.5.7...v6.6.0) --- updated-dependencies: - dependency-name: elliptic dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…ebWebsite/Tests (#2574) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…er disposal of async resources (#2521)
Co-authored-by: James Newton-King <[email protected]>
…ServerServiceDefinition (#1) * support MapGrpcService with ServerServiceDefinition * support MapGrpcService with ServerServiceDefinition * rename sample solution file * create factory method * remove extra using * fix sample project for ServerServiceDefinition mapping * implement Metadata creation for ServerServiceDefinition * implement unit test for MapGrpcService for ServerServiceDefinition --------- Co-authored-by: aka-nse <[email protected]>
…ttps://github.com/aka-nse/grpc-dotnet into feature/MapGrpcService-with-ServerServiceDefinition
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Is your feature request related to a problem? Please describe.
This PR is implement for #2236.
ServerServiceDefinitionis defined in Grpc.Core.Api library, and it was a prefer way to implement gRPC server with Grpc.Core.In current grpc-dotnet, the server should be implemented on Asp.Net web application DI container via
GrpcEndpointRouteBuilderExtensions.MapGrpcServicegeneric method.The APIs in this proposal bridges legacy way into grpc-dotnet to enable to migrate easier.
Describe the solution you'd like
2 overloads of
GrpcEndpointRouteBuilderExtensions.MapGrpcServiceare added:This change enables to map gRPC services via
Grpc.Core.ServerServiceDefinition, therefore migration from Grpc.Core can be more easier.Changes in this PR
Grpc.Core.ApiGrpc.Core.ServerServiceDefinition.BindService(ServiceBinderBase)method as public*Grpc.AspNetCore.ServerMicrosoft.AspNetCore.Builder.GrpcEndpointRouteBuilderExtensionsclassMapGrpcService(this IEndpointRouteBuilder, ServerServiceDefinition)*MapGrpcService(this IEndpointRouteBuilder, Func<IServiceProvider, ServerServiceDefinition>)*ServerCallHandlerFactoryandServiceRouteBuilder(non-generic) onMicrosoft.Extensions.DependencyInjection.AddServiceOptionsmethod**Grpc.AspNetCore.Server.Internal.EndpointServiceBinderto bind methods inServerServiceDefinitioninto ASP.Net core web application server*Grpc.AspNetCore.Server.Internal.ServerCallHandlerFactoryclass*Grpc.AspNetCore.Server.Model.Internal.ServiceRouteBuilderclass*ServerCallHandlerBase*,UnaryServerCallhandler*,ServerStreamingServerCallHandler*,ClientStreamingServerCallHandler*, andDuplexStreamingServerCallHandler* classes inGrpc.AspNetCore.Server.Internal.CallHandlersnamespaceServerMethodInvokerBase*,UnaryServerMethodInvoker*,ServerStreamingServerMethodInvoker*,ClientStreamingServerMethodInvoker*, andDuplexStreamingServerMethodInvoker* classes inGrpc.Shared.ServernamespaceServerCallHandlerFactoryandServerCallHandlerFactory<TService>intoIServerCallHandlerFactory*test
MapGrpcServiceexamples
Grpc.AspNetCore.Server.Tests.TestObjects.Services.WithAttribute.GreeterWithAttribute.BindServicemethodDescribe alternatives you've considered
This commit contains concrete code as far as I can write, but I do not care about these implementations.
I welcome better ways to realize this suggestion.
Additional context
No response