Upgrade dotnet-grpc dependencies#1914
Merged
Merged
Conversation
JamesNK
requested review from
BrennanConroy,
brunolins16,
captainsafia and
halter73
JamesNK
changed the title
captainsafia
approved these changes
Oct 17, 2022
captainsafia
left a comment
captainsafia
left a comment
Contributor
There was a problem hiding this comment.
Do we have a CTI test for this scenario? The issue report indicates that it happens in a new project. Could we augment this scenario with some invocations to the CLI to validate?
Member
Author
|
A good idea but |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1906
I updated the MSBuild packages used to locate and load projects, and that fixed the commend line tool being used with .NET 7 apps.
I also updated some other packages used by the tool in this PR. System.Comandline required some reactions (as usual...)