Fix build failure on benchmark server#1913
Merged
Merged
Conversation
davidfowl
approved these changes
Oct 17, 2022
Contributor
|
@sebastienros is this because of your change in crank to modify the transitive project references TFM? |
Contributor
|
I changed crank to patch projects directly referenced by the main app to also target the same TFM. |
Member
Author
|
That change caused Grpc.Core.Api to fail. It isn't designed to run with a newer TFM. I think it's fixed here, but other people might be impacted. Also, the change only happened in Linux. Windows builds continued to succeed. |
Contributor
|
Ok, this project is a library targeting netstandard, so I assume I should not have patched it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For some reason, the Grpc.Core.Api project is being built targeting .NET 7. This only happens on Linux.
These are useful changes to make because Grpc.Core.Api will target a new version of .NET at some point. Still, I'm confused why build has started behaving this way. Bug in 8.0 alpha SDK? 🤷
https://dev.azure.com/dnceng/internal/_build/results?buildId=2020161&view=logs&j=c8217af0-de7d-5e68-361c-a1e6c44be6a1&t=08f9ece3-b1e6-51ce-7219-b24eb80cfd7d