Skip to content

Fix grpc benchmark cancellation#1901

Merged
JamesNK merged 1 commit into
masterfrom
brecon/cancel
Oct 5, 2022
Merged

Fix grpc benchmark cancellation#1901
JamesNK merged 1 commit into
masterfrom
brecon/cancel

Conversation

@BrennanConroy

Copy link
Copy Markdown
Contributor

Methods on CallOptions return a new instance of the options struct.

@BrennanConroy BrennanConroy requested a review from JamesNK October 5, 2022 16:42
@linux-foundation-easycla

linux-foundation-easycla Bot commented Oct 5, 2022

Copy link
Copy Markdown

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: BrennanConroy / name: Brennan (87bde8e)

@BrennanConroy

BrennanConroy commented Oct 5, 2022

Copy link
Copy Markdown
Contributor Author

Still didn't help even if it is correct...

Edit: Branch wasn't being picked up, fixing command line shows this did fix the benchmark

@JamesNK JamesNK merged commit ad67dc8 into master Oct 5, 2022
@BrennanConroy BrennanConroy deleted the brecon/cancel branch October 5, 2022 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants