Use the extending class name when throwing ObjectDisposedException#1890
Merged
JamesNK merged 1 commit intoSep 26, 2022
Conversation
JamesNK
approved these changes
Sep 23, 2022
Member
|
Good spotting. Thanks for the PR! |
Contributor
Author
|
Thanks @JamesNK. This is my first contribution to this project and I don't know if I have to do something else now that the PR has been approved. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Don't use the DnsResolver class name but the extending class name when throwing the ObjectDisposedException in the PollingResolver.Resolve() method