Skip to content

Fix detecting message accept encoding with whitespace#1882

Merged
JamesNK merged 2 commits into
grpc:masterfrom
JamesNK:jamesnk/message-accept-encoding-whitespace
Sep 14, 2022
Merged

Fix detecting message accept encoding with whitespace#1882
JamesNK merged 2 commits into
grpc:masterfrom
JamesNK:jamesnk/message-accept-encoding-whitespace

Conversation

@JamesNK

@JamesNK JamesNK commented Sep 13, 2022

Copy link
Copy Markdown
Member

Fixes #1881

@captainsafia captainsafia left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small non-block comment on test coverage.

Comment thread test/FunctionalTests/Server/CompressionTests.cs
Comment thread test/FunctionalTests/Server/CompressionTests.cs
@JamesNK JamesNK merged commit 9852674 into grpc:master Sep 14, 2022
@JamesNK JamesNK deleted the jamesnk/message-accept-encoding-whitespace branch September 14, 2022 00:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Response is not compressed when Grpc-Accept-Encoding header contains spaces between values

2 participants