Change examples to use WebApplication V4#1879
Merged
Merged
Conversation
JamesNK
requested review from
BrennanConroy,
brunolins16,
captainsafia and
halter73
| builder.Services.AddGrpc(); | ||
| builder.Services.AddSingleton<TicketRepository>(); | ||
|
|
||
| builder.Services.AddAuthorization(options => |
Contributor
There was a problem hiding this comment.
Have you considered using the new AuthorizationBuilder model here. Should be something like this:
services.AddAuthorization().AddPolicy(
JwtBearerDefaults.AuthenticationScheme,
policy => {
policy.AddAuthenticationSchemes(JwtBearerDefaults.AuthenticationScheme);
policy.RequireClaim(ClaimTypes.Name);
});
Member
Author
There was a problem hiding this comment.
This isn't available for me. Perhaps the .NET 7 version with it isn't out yet.
Contributor
There was a problem hiding this comment.
Oh interesting...they should've been a part of the preview7 release...
In any case, not a huge deal...
JamesNK
force-pushed
the
jamesnk/examples/webapp-v4
branch
from
8d023fb to
047c9eb
Compare
captainsafia
approved these changes
Sep 13, 2022
JamesNK
force-pushed
the
jamesnk/examples/webapp-v4
branch
from
8f7762f to
3833830
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Done