Skip to content

Fix using disposed token in connect and resulting status#1872

Merged
JamesNK merged 1 commit into
grpc:masterfrom
JamesNK:jamesnk/subchannel-connect-bug
Sep 1, 2022
Merged

Fix using disposed token in connect and resulting status#1872
JamesNK merged 1 commit into
grpc:masterfrom
JamesNK:jamesnk/subchannel-connect-bug

Conversation

@JamesNK

@JamesNK JamesNK commented Sep 1, 2022

Copy link
Copy Markdown
Member

Fixes #1870

Two bugs:

  • If a connect is in progress when the context is disposed then the next time the cancellation token is accessed an error will get thrown. Take a copy of the cancellation token to avoid this error.
  • The subchannel connectivity state updates to TransientFailure when this error happens. The problem is the status is incorrectly reported as OK. Fixed by using the right overload.

@JamesNK JamesNK merged commit 792eb3b into grpc:master Sep 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ArgumentException: Error status code must not be OK

2 participants