revert setting of PayloadConfig in ServerConfig of non-generic server#9612
Merged
apolcyn merged 3 commits intogrpc:masterfrom Feb 9, 2017
Merged
Conversation
Contributor
Author
|
c# performance tests passing here |
jtattermusch
reviewed
Feb 8, 2017
Contributor
There was a problem hiding this comment.
why does PayloadConfig needs to be set? For AsyncServer (= non-generic), the request should contain the payload config to use for the response, so something is wrong here.
Which PR have populated payload_config?
Contributor
Author
Contributor
Contributor
|
To set response size for non-generic servers, should be set in client's payload_config. |
apolcyn
changed the title
Contributor
Author
Contributor
Author
|
re-ran generate projects jenkins: test this please |
apolcyn
force-pushed
the
fix_csharp_benchmark_server_startups
branch
from
187beef to
923f8a3
Compare
Contributor
Author
|
sanity still failing, rebased - not sure if this PR yet. jenkins: test this please |
apolcyn
force-pushed
the
fix_csharp_benchmark_server_startups
branch
from
923f8a3 to
e0aed71
Compare
Contributor
Author
|
sanity should be fixed now. jenkins: test this please |
Contributor
Author
|
test failures in: |
lidizheng
pushed a commit
to lidizheng/grpc
that referenced
this pull request
Feb 12, 2021
To better support config dump, deprecated field detection and other debug, it's helpful to leave a type name breadcrumb and be able to synthesize a Protobuf::Message that corresponds to what was delivered on the wire. While working on this PR, it became apparent that config dump is broken post v3alpha, since a single config dump might have both v2 and v3 Listeners, etc. The only way to resolve this generically is to make the inner resources in config dump Any. This is a breaking API change, but these are v2alpha/v3alpha at this point, so allowed. Risk level: Low Testing: new version converter unit test, config dump tests now verify that the correct versioned inner resource is returned. Fixes grpc#9612 Signed-off-by: Harvey Tuch <[email protected]> Mirrored from https://github.com/envoyproxy/envoy @ 233838a39fb8310ea145e7d758d428d5a37b0306
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #9587
changes to scenario config set
PayloadConfigforAsyncServer(protobuf config) - previous null check now failing.