add missing return in scenario config#9580
Merged
apolcyn merged 2 commits intogrpc:masterfrom Feb 3, 2017
Merged
Conversation
dgquintas
approved these changes
Feb 3, 2017
Contributor
dgquintas
left a comment
dgquintas
left a comment
There was a problem hiding this comment.
Love these type of fixes :)
Thanks!
ctiller
approved these changes
Feb 3, 2017
Contributor
Author
|
jenkins: test this please |
This was referenced Feb 3, 2017
Contributor
Author
|
tes failures on:
|
lidizheng
pushed a commit
to lidizheng/grpc
that referenced
this pull request
Feb 12, 2021
This patch introduces a new checker, tools/api/validate_structure.py, that is run as part of the bazel.api CI job. It ensures that the package layout for the API doesn't violate some constraints, largely reflecting the heuristics we used for v3alpha migration. Along the way, I discovered there were some packages that were versionless and not boosted to v3alpha, and there were some extensions left behind in envoy.config. These are fixed as well to allow the validation to succeed. Risk level: Low Testing: tools/api/validate_structure.py passes, bazel test //test/... Fixes grpc#9580 Signed-off-by: Harvey Tuch <[email protected]> Mirrored from https://github.com/envoyproxy/envoy @ 29b30911dbfb3f9760efeb28238ceac36e1a1a23
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #9579