Merged
Conversation
sreecha
approved these changes
Jan 19, 2017
sreecha
approved these changes
Jan 20, 2017
jtattermusch
reviewed
Feb 8, 2017
| # For proto payload, only the client should get the config. | ||
| scenario['client_config']['payload_config'] = EMPTY_PROTO_PAYLOAD | ||
| scenario['client_config']['payload_config'] = _payload_type(use_generic_payload, req_size, resp_size) | ||
| scenario['server_config']['payload_config'] = _payload_type(use_generic_payload, req_size, resp_size) |
Contributor
There was a problem hiding this comment.
I think the problem here is that payload_config should only be set for client for non-generic server. The reason is that the non-generic server (Async and Sync) are supposed to respond with a message size that corresponds to what is requested in SimpleRequest (which is constructed based on client's payload config).
Setting payload config for a server should be illegal (and so C# qps worker is asserting that it is only set for generic server), which is what's breaking C# benchmarks (#9587).
grpc/src/proto/grpc/testing/control.proto
Line 143 in 2e096b0
grpc/test/cpp/qps/server_async.cc
Line 366 in f9b8730
Contributor
|
Two problems with this PR:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.