Merged
Conversation
Contributor
There was a problem hiding this comment.
I wouldn't use WORKDIR as that has lasting effect for the final docker image being built.
RUN cd /usr/src && wget FOO && tar BAR works just as well
Same below.
jtattermusch
approved these changes
Dec 22, 2016
Contributor
jtattermusch
left a comment
jtattermusch
left a comment
There was a problem hiding this comment.
LGTM after addressing the comment.
matt-kwong
force-pushed
the
fix-python-artifact
branch
from
9040bf5 to
346f9e4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes https://grpc-testing.appspot.com/view/Artifacts/job/gRPC_build_artifacts/architecture=x86,language=python,platform=linux/