Reintroduce test timeouts eliminated by mistake#9161
Merged
jtattermusch merged 1 commit intogrpc:masterfrom Dec 20, 2016
Merged
Reintroduce test timeouts eliminated by mistake#9161jtattermusch merged 1 commit intogrpc:masterfrom
jtattermusch merged 1 commit intogrpc:masterfrom
Conversation
matt-kwong
approved these changes
Dec 19, 2016
Contributor
matt-kwong
left a comment
matt-kwong
left a comment
There was a problem hiding this comment.
LGTM although it looks like #9158 has all of these changes already
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #7027, timeouts for some languages were disabled by mistake:
https://github.com/grpc/grpc/pull/7027/files#diff-e499007ead3313db2f7c0ba03e003581L107
(argument
bin_hashwas removed and that made positional argumentNonebeing interpreted as timeout_seconds).This restores the default timeouts for C#, Node, PHP.
It also adds a timeout for ObjC tests and sanity (because all tests should have SOME timeout).
Lesson learned:
FYI
@stanley-cheung @murgatroid99 @makdharma @ctiller