Skip to content

Patch overlooked strings from Python un-namespacing#9094

Merged
soltanmm-google merged 2 commits intogrpc:v1.0.xfrom
soltanmm-google:praytell-babbage-if-you-do-the-wrong-thing-will-it-still-do-the-right-thing
Dec 14, 2016
Merged

Patch overlooked strings from Python un-namespacing#9094
soltanmm-google merged 2 commits intogrpc:v1.0.xfrom
soltanmm-google:praytell-babbage-if-you-do-the-wrong-thing-will-it-still-do-the-right-thing

Conversation

@soltanmm-google
Copy link
Copy Markdown
Contributor

@soltanmm-google soltanmm-google commented Dec 13, 2016 •
edited
Loading

Failures: #9046, #9117, #9047

@soltanmm-google soltanmm-google added this to the 1.0.x milestone Dec 13, 2016
@soltanmm-google
Copy link
Copy Markdown
Contributor Author

soltanmm-google commented Dec 13, 2016 •
edited
Loading

https://grpc-testing.appspot.com/view/Artifacts/job/gRPC_build_artifacts/2365/
https://grpc-testing.appspot.com/view/Artifacts/job/gRPC_build_artifacts/2372/

@soltanmm-google
Copy link
Copy Markdown
Contributor Author

soltanmm-google commented Dec 13, 2016

If interop tests appear to work nicely, then yay, if they don't, then back to the drawing board.

@soltanmm-google
Copy link
Copy Markdown
Contributor Author

soltanmm-google commented Dec 14, 2016

Well, instead of a segfault there's a timeout. That's... almost progress. Still can't get v1.0.x to fail to build locally in the first place.

@soltanmm-google
Copy link
Copy Markdown
Contributor Author

soltanmm-google commented Dec 14, 2016

Running this branch manually on the interop test machine doesn't show any irregularities, and building shouldn't have any race conditions (heck as much as I'd wanted to make the build parallel distutils doesn't allow that). This is weird. Really, really weird.

atash@grpc-canary-interop3:~/grpc$ time ./tools/run_tests/run_interop_tests.py -l python -s python --use_docker
Seen --use_docker flag, will run interop tests under docker.

IMPORTANT: The changes you are testing need to be locally committed
because only the committed changes in the current branch will be
copied to the docker environment.
START: Building interop docker images.
PASSED: build_docker_python [time=340.8sec; retries=0:0]
SUCCESS: All docker images built successfully.
START: interop_server_python
PASSED: cloud_to_cloud:python:python_server:large_unary [time=2.6sec; retries=0:0]
PASSED: cloud_to_cloud:python:python_server:empty_unary [time=2.6sec; retries=0:0]
PASSED: cloud_to_cloud:python:python_server:ping_pong [time=2.6sec; retries=0:0]
PASSED: cloud_to_cloud:python:python_server:empty_stream [time=2.6sec; retries=0:0]
PASSED: cloud_to_cloud:python:python_server:client_streaming [time=2.6sec; retries=0:0]
PASSED: cloud_to_cloud:python:python_server:server_streaming [time=2.6sec; retries=0:0]
PASSED: cloud_to_cloud:python:python_server:cancel_after_begin [time=2.9sec; retries=0:0]
PASSED: cloud_to_cloud:python:python_server:timeout_on_sleeping_server [time=3.4sec; retries=0:0]
PASSED: cloud_to_cloud:python:python_server:cancel_after_first_response [time=3.4sec; retries=0:0]
SUCCESS: All tests passed
Removing docker image grpc_interop_python:4b11cf42-6723-4f58-8b7c-cd9f659b1700

real	5m52.178s
user	0m0.684s
sys	0m0.596s
atash@grpc-canary-interop3:~/grpc$ git branch
  jenkins-docker
  master
* praytell-babbage-if-you-do-the-wrong-thing-will-it-still-do-the-right-thing
  v1.0.x

@soltanmm-google soltanmm-google force-pushed the praytell-babbage-if-you-do-the-wrong-thing-will-it-still-do-the-right-thing branch from 8ed1bbe to fe83944 Compare December 14, 2016 19:49
@soltanmm-google
Copy link
Copy Markdown
Contributor Author

soltanmm-google commented Dec 14, 2016

Might fix #9108.

@soltanmm-google soltanmm-google force-pushed the praytell-babbage-if-you-do-the-wrong-thing-will-it-still-do-the-right-thing branch from fe83944 to 9fb054a Compare December 14, 2016 19:52
nathanielmanistaatgoogle
nathanielmanistaatgoogle suggested changes Dec 14, 2016
View reviewed changes
src/python/grpcio_health_checking/MANIFEST.in
@@ -1,4 +1,4 @@
include grpc_version.py
include health_commands.py
graft grpc
Copy link
Copy Markdown
Contributor

@nathanielmanistaatgoogle nathanielmanistaatgoogle Dec 14, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand how the change on this line relates to the rest of the pull request. Have I missed something in the commit messages?

Copy link
Copy Markdown
Contributor Author

@soltanmm-google soltanmm-google Dec 14, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's changed for the same reason as everything else: things used to be in a package called grpc, and are now in a package called grpc_$SOMETHING.

tools/distrib/python/grpcio_tools/MANIFEST.in
include protoc_deps.py
include protoc_lib_deps.py
include README.rst
graft grpc
Copy link
Copy Markdown
Contributor

@nathanielmanistaatgoogle nathanielmanistaatgoogle Dec 14, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here too.

Copy link
Copy Markdown
Contributor Author

@soltanmm-google soltanmm-google Dec 14, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See above.

@soltanmm-google soltanmm-google merged commit 71f4f20 into grpc:v1.0.x Dec 14, 2016
@soltanmm-google soltanmm-google deleted the praytell-babbage-if-you-do-the-wrong-thing-will-it-still-do-the-right-thing branch December 14, 2016 22:13
@dgquintas
Copy link
Copy Markdown
Contributor

dgquintas commented Dec 16, 2016

Please document failures. If no issue exists, create one and assign it. If one exists, ping it and/or assign it.

@soltanmm-google
Copy link
Copy Markdown
Contributor Author

soltanmm-google commented Dec 16, 2016

Done.

@lock lock bot locked as resolved and limited conversation to collaborators Jan 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@nathanielmanistaatgoogle nathanielmanistaatgoogle nathanielmanistaatgoogle approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@nathanielmanistaatgoogle nathanielmanistaatgoogle

Labels

cla: yes

Projects

None yet

Milestone

1.0.x

Development

Successfully merging this pull request may close these issues.

4 participants

@soltanmm-google @dgquintas @nathanielmanistaatgoogle @googlebot