Skip to content

Interop fixes#9045

Merged
nathanielmanistaatgoogle merged 2 commits intogrpc:v1.0.xfrom
nathanielmanistaatgoogle:interop-fixes-v1.0.x
Dec 13, 2016
Merged

Interop fixes#9045
nathanielmanistaatgoogle merged 2 commits intogrpc:v1.0.xfrom
nathanielmanistaatgoogle:interop-fixes-v1.0.x

Conversation

@nathanielmanistaatgoogle
Copy link
Copy Markdown
Contributor

No description provided.

It was a mistake that requests might be sent; the test specification
calls for no requests to be sent. It was a mistake that the response
future's cancelled() method was called; the cancelled() method returns
something more like "was this object's cancel() method called earlier?"
than "did the RPC terminate with status code CANCELLED?". Since it's
something that we'd well enough like to work I've retained the
cancelled() call with a different failure message.
@nathanielmanistaatgoogle
Copy link
Copy Markdown
Contributor Author

No thoughts on this yet?

@nathanielmanistaatgoogle
Copy link
Copy Markdown
Contributor Author

@nathanielmanistaatgoogle nathanielmanistaatgoogle merged commit d0e336a into grpc:v1.0.x Dec 13, 2016
@nathanielmanistaatgoogle nathanielmanistaatgoogle deleted the interop-fixes-v1.0.x branch December 13, 2016 19:59
@lock lock bot locked as resolved and limited conversation to collaborators Jan 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants