Address comments from #8913. Also make changes needed for import.#8979
Merged
markdroth merged 13 commits intogrpc:masterfrom Dec 9, 2016
Merged
Address comments from #8913. Also make changes needed for import.#8979markdroth merged 13 commits intogrpc:masterfrom
markdroth merged 13 commits intogrpc:masterfrom
Conversation
markdroth
changed the title
jboeuf
approved these changes
Dec 8, 2016
| // Create handshakers. | ||
| grpc_security_create_handshakers(exec_ctx, tsi_hs, &sc->base, handshake_mgr); | ||
| grpc_handshake_manager_add(handshake_mgr, grpc_security_handshaker_create( | ||
| exec_ctx, tsi_hs, &sc->base)); |
Contributor
There was a problem hiding this comment.
did you clang-format? Indentation looks off.
Contributor
There was a problem hiding this comment.
oh actually, you did. Weird...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the last part of fixing #8744.