Skip to content

add ruby subclasses of bad status for each GPRC status code#8879

Merged
apolcyn merged 3 commits intogrpc:v1.0.xfrom
apolcyn:ruby_subclass_badstatus
Dec 15, 2016
Merged

add ruby subclasses of bad status for each GPRC status code#8879
apolcyn merged 3 commits intogrpc:v1.0.xfrom
apolcyn:ruby_subclass_badstatus

Conversation

@apolcyn
Copy link
Copy Markdown
Contributor

@apolcyn apolcyn commented Nov 29, 2016

fixes #7253

@murgatroid99
Copy link
Copy Markdown
Member

You should also change the client code to actually use these status subclasses. I would recommend adding a static factory function to BadStatus that creates the correct subclass based on the code.

@apolcyn
Copy link
Copy Markdown
Contributor Author

apolcyn commented Dec 5, 2016

test this please

@apolcyn
Copy link
Copy Markdown
Contributor Author

apolcyn commented Dec 14, 2016

jenkins: test this please

@apolcyn
Copy link
Copy Markdown
Contributor Author

apolcyn commented Dec 15, 2016

@apolcyn apolcyn merged commit 32b2ecc into grpc:v1.0.x Dec 15, 2016
@lock lock bot locked as resolved and limited conversation to collaborators Jan 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants